feat: ability to add titles for the links #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyzyl-ool
requested review from
gorgeousvlad and
yuberdysheva
as code owners
|
Preview is ready. |
Kyzyl-ool
force-pushed
the
feat/a11y-anchor-titles
branch
from
89b065c to
b9cc8fe
Compare
Kyzyl-ool
force-pushed
the
feat/a11y-anchor-titles
branch
from
b9cc8fe to
e9056c2
Compare
| <a href={url} title={text} className={classes} {...rest} {...linkExtraProps}> | ||
| <a | ||
| href={url} | ||
| title={urlTitle || text} |
There was a problem hiding this comment.
why is there a fallback to the text in this place but not in all places?
There was a problem hiding this comment.
For backward compatibility I left fallback here. But I didn't do one on other places to avoid unexpected tooltips. Moreover, I expect that the link text and link title will not be the same
| const iconData = getMediaImage(icon); | ||
| const {alt} = iconData; | ||
|
|
||
| return ( | ||
| <a | ||
| href={url} | ||
| aria-label={alt} | ||
| title={alt} | ||
| title={urlTitle || alt} |
There was a problem hiding this comment.
Can alt of icon be the title of a link?
There was a problem hiding this comment.
Yes, but the accessible name will be read by screenreader in this order:
- link text
- image alt
- link title
Is icon's alt is the same as the link title, the screenreader will read two sentences twice, it is not really good. So I think they should differ
yuberdysheva
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlTitleeverywhere where links (<a>tags) were used.This feature can be used to provide both visual and accessible warning that the link will open in a new tab
Closes #484 and #485